-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send zookeeper logs to standard out #14
base: master
Are you sure you want to change the base?
Conversation
@mannytoledo Could this be optional and have the linking be done as a conditional if an environment variable is passed into the container? |
@brandongalbraith Is there a use case where a user wouldn't want zookeeper logs accessible from the running container? I originally though of making it optional but figured the app this container wraps should be accessible via docker logs. |
@mannytoledo Not sure about a use case where you wouldn't want logs; I'm thinking about people already using this in production who are expecting a certain behavior (logs not send to stdout). |
@brandongalbraith Fair enough, expect an update on this soon. |
Thanks @mannytoledo! |
I went ahead and made that optional @brandongalbraith @mbabineau Let me know what you guys think. |
Thanks @mannytoledo for this PR. |
See http://www.jamescoyle.net/cheat-sheets/676-logrotate-cheat-sheet on how to logrotate zookeeper.out. A suggestion would be:
placed in a file such as |
Thanks @brandongalbraith. I will add that to my docker container |
@panda87 You'd set that up on your host running the docker container, not On Monday, May 2, 2016, panda87 [email protected] wrote:
|
This is the best practice? because the json file log is located in the /var/lib/docker dir |
Redirecting zookeeper output to stdout to make it easier to monitor with standard docker tools.