[#2893] Remove search from mobile menu #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
issue/2893-search-menu-mobile
branch
from
c09cdb4 to
9f12143
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1511 +/- ##
========================================
Coverage 94.31% 94.31%
========================================
Files 1068 1068
Lines 40386 40386
========================================
Hits 38089 38089
Misses 2297 2297 ☔ View full report in Codecov by Sentry. |
|
@jiromaykin should take a quick look as well when he's back |
swrichards
approved these changes
Dec 3, 2024
|
Fine if this works, however a neater approach would be to remove it from components/Header/Header.html. But considering the complexity of this template I agree with doing this via CSS for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2893