Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix ci build #338

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(ci): fix ci build #338

wants to merge 2 commits into from

Conversation

niladrih
Copy link
Member

Signed-off-by: Niladri Halder [email protected]

Pull Request template

Please, go through these steps before you submit a PR. ## Remove this line

Why is this PR required? What issue does it fix?:

What this PR does?:

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:

Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

PR title/commit message must follow convention: <type>(<scope>): <subject>.

Most common types are:
* `feat`      - for new features, not a new feature for build script
* `fix`       - for bug fixes or improvements, not a fix for build script
* `chore`     - changes not related to production code
* `docs`      - changes related to documentation
* `style`     - formatting, missing semi colons, linting fix etc; no significant production code changes
* `test`      - adding missing tests, refactoring tests; no production code change
* `refactor`  - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant