Fix linting errors #915
Fix linting errors #915
Conversation
dhogan8
force-pushed
the
dallas/fix-linting-errors
branch
from
f681ef7
to
b99fb63
Compare
Deploying blog-site with
|
| Latest commit: |
b164d44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://01f1b8b9.blog-site-602.pages.dev |
| Branch Preview URL: | https://dallas-fix-linting-errors.blog-site-602.pages.dev |
dhogan8
force-pushed
the
dallas/fix-linting-errors
branch
12 times, most recently
from
9bd8867
to
b566d9d
Compare
dhogan8
force-pushed
the
dallas/fix-linting-errors
branch
3 times, most recently
from
16016fe
to
b566d9d
Compare
dhogan8
force-pushed
the
dallas/fix-linting-errors
branch
from
b566d9d
to
3674fdf
Compare
.github/workflows/precious.yml
Outdated
| @@ -0,0 +1,45 @@ | |||
| name: Precious | |||
There was a problem hiding this comment.
We probably don't need a Precious github action since we already have a linting github action, which lints the whole repo; linting the whole is preferred in CI since things like node module updates could catch linting errors that a git diff list would miss.
There was a problem hiding this comment.
It wasn't clear to me why the linting.yml file didn't fail with all of the errors that were fixed in this PR though.
There was a problem hiding this comment.
The beauty of precious is that we can run all sorts of linters and tidiers. For the blog, I would think adding something like typos would be helpful. I guess we could still run that via the node scripts, but that gets cumbersome really quickly.
There was a problem hiding this comment.
It wasn't clear to me why the linting.yml file didn't fail with all of the errors that were fixed in this PR though.
It's because warnings don't return a non-zero exit code.
To fix this in stylelint, change defaultSeverity to error.
For eslint, add the --max-warnings=0 cli argument
There was a problem hiding this comment.
Adding something for typos does seem ideal for something like the blog site.
Thanks, I've removed the precious github action in b164d44 if it is preferred to use only the linting github action.
| #!/usr/bin/env bash | ||
|
|
||
| # This is for installing precious and other 3rd party libs needed for linting | ||
| # in CI |
There was a problem hiding this comment.
I guess this script would also need to be run at least once in dev environments, yeah?
|
|
||
| You should also install our pre-commit hook. You can do this from your checkout | ||
| by running `git/setup.sh`. These hooks do things like ensure that the code you | ||
| commit is tidy and passes various linter checks. |
There was a problem hiding this comment.
This should also mention that precious needs to be installed and how to install it. For instance, I sometimes work on the blog site locally on my computer which currently doesn't have precious installed.
No description provided.