New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix multiple replacement on the same path #541

Merged

barryvdh merged 1 commit into maximebf:master from erikn69:patch-1

Aug 18, 2023

Contributor

erikn69 commented Jul 17, 2023 •

edited

Loading

If you have small, common paths on the server, it will replace all matches, not just the prefix

$xdebugReplacements = [
      '/App' => 'C:\local',
      '/www' => 'C:\local',
  ];
$file = '/App/MyApp/www/Controller/AppController.php';
$class->getXdebugLink($file);
// Expected:
// "C:\local/MyApp/www/Controller/AppController.php"
// Actual:
// "C:\local/MyAppC:\local/ControllerC:\localController.php"


Fix multiple replacement on the same path

b1eb96d

erikn69 force-pushed the patch-1 branch from c308db6 to b1eb96d Compare

July 17, 2023 20:48

barryvdh merged commit 48c36d1 into maximebf:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment