feature #51804 [Security] Make impersonation_path() argument mandat…
#11
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Unit Tests | |
| on: | |
| push: | |
| pull_request: | |
| defaults: | |
| run: | |
| shell: bash | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| permissions: | |
| contents: read | |
| jobs: | |
| tests: | |
| name: Unit Tests | |
| env: | |
| extensions: amqp,apcu,igbinary,intl,mbstring,memcached,redis,relay | |
| strategy: | |
| matrix: | |
| include: | |
| - php: '8.1' | |
| - php: '8.2' | |
| mode: high-deps | |
| - php: '8.2' | |
| mode: low-deps | |
| - php: '8.3' | |
| #mode: experimental | |
| fail-fast: false | |
| runs-on: ubuntu-20.04 | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 2 | |
| - name: Setup PHP | |
| uses: shivammathur/setup-php@v2 | |
| with: | |
| coverage: "none" | |
| ini-values: date.timezone=UTC,memory_limit=-1,default_socket_timeout=10,session.gc_probability=0,apc.enable_cli=1,zend.assertions=1 | |
| php-version: "${{ matrix.php }}" | |
| extensions: "${{ env.extensions }}" | |
| tools: flex | |
| - name: Configure environment | |
| run: | | |
| git config --global user.email "" | |
| git config --global user.name "Symfony" | |
| git config --global init.defaultBranch main | |
| git config --global advice.detachedHead false | |
| (php --ri relay 2>&1 > /dev/null) || sudo rm /etc/php/*/cli/conf.d/20-relay.ini | |
| COMPOSER_HOME="$(composer config home)" | |
| ([ -d "$COMPOSER_HOME" ] || mkdir "$COMPOSER_HOME") && cp .github/composer-config.json "$COMPOSER_HOME/config.json" | |
| echo COLUMNS=120 >> $GITHUB_ENV | |
| echo PHPUNIT="$(pwd)/phpunit --exclude-group tty,benchmark,intl-data,integration" >> $GITHUB_ENV | |
| echo COMPOSER_UP='composer update --no-progress --ansi'$([[ "${{ matrix.mode }}" != low-deps ]] && echo ' --ignore-platform-req=php+') >> $GITHUB_ENV | |
| SYMFONY_VERSIONS=$(git ls-remote -q --heads | cut -f2 | grep -o '/[1-9][0-9]*\.[0-9].*' | sort -V) | |
| SYMFONY_VERSION=$(grep ' VERSION = ' src/Symfony/Component/HttpKernel/Kernel.php | cut -d "'" -f2 | cut -d '.' -f 1-2) | |
| SYMFONY_FEATURE_BRANCH=$(curl -s https://raw.githubusercontent.com/symfony/recipes/flex/main/index.json | jq -r '.versions."dev-name"') | |
| # Install the phpunit-bridge from a PR if required | |
| # | |
| # To run a PR with a patched phpunit-bridge, first submit the patch for the | |
| # phpunit-bridge as a separate PR against the next feature-branch then | |
| # uncomment and update the following line with that PR number | |
| #SYMFONY_PHPUNIT_BRIDGE_PR=32886 | |
| if [[ $SYMFONY_PHPUNIT_BRIDGE_PR ]]; then | |
| git fetch --depth=2 origin refs/pull/$SYMFONY_PHPUNIT_BRIDGE_PR/head | |
| git rm -rq src/Symfony/Bridge/PhpUnit | |
| git checkout -q FETCH_HEAD -- src/Symfony/Bridge/PhpUnit | |
| SYMFONY_PHPUNIT_BRIDGE_REF=$(curl -s https://api.github.com/repos/symfony/symfony/pulls/$SYMFONY_PHPUNIT_BRIDGE_PR | jq -r .base.ref) | |
| sed -i 's/"symfony\/phpunit-bridge": ".*"/"symfony\/phpunit-bridge": "'$SYMFONY_PHPUNIT_BRIDGE_REF'.x@dev"/' composer.json | |
| rm -rf .phpunit | |
| fi | |
| # Create local composer packages for each patched components and reference them in composer.json files when cross-testing components | |
| if [[ ! "${{ matrix.mode }}" = *-deps ]]; then | |
| php .github/build-packages.php HEAD^ $SYMFONY_VERSION src/Symfony/Bridge/PhpUnit | |
| else | |
| echo SYMFONY_DEPRECATIONS_HELPER=weak >> $GITHUB_ENV | |
| cp composer.json composer.json.orig | |
| echo -e '{\n"require":{'"$(grep phpunit-bridge composer.json)"'"php":"*"},"minimum-stability":"dev"}' > composer.json | |
| php .github/build-packages.php HEAD^ $SYMFONY_VERSION $(find src/Symfony -mindepth 2 -type f -name composer.json -printf '%h\n' | grep -v src/Symfony/Component/Intl/Resources/emoji) | |
| mv composer.json composer.json.phpunit | |
| mv composer.json.orig composer.json | |
| fi | |
| if [[ $SYMFONY_PHPUNIT_BRIDGE_PR ]]; then | |
| git rm -fq -- src/Symfony/Bridge/PhpUnit/composer.json | |
| git diff --staged -- src/Symfony/Bridge/PhpUnit/ | git apply -R --index | |
| fi | |
| # For the highest branch, in high-deps mode, the version before it is checked out and tested with the locally patched components | |
| if [[ "${{ matrix.mode }}" = high-deps && $SYMFONY_VERSION = $(echo "$SYMFONY_VERSIONS" | tail -n 1 | sed s/.//) ]]; then | |
| echo FLIP='^' >> $GITHUB_ENV | |
| SYMFONY_VERSION=$(echo "$SYMFONY_VERSIONS" | grep -FB1 /$SYMFONY_VERSION | head -n 1 | sed s/.//) | |
| git fetch --depth=2 origin $SYMFONY_VERSION | |
| git checkout -m FETCH_HEAD | |
| echo COMPONENTS=$(find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist -printf '%h ') >> $GITHUB_ENV | |
| fi | |
| # Skip the phpunit-bridge on bugfix-branches when not in *-deps mode | |
| if [[ ! "${{ matrix.mode }}" = *-deps && $SYMFONY_VERSION != $SYMFONY_FEATURE_BRANCH ]]; then | |
| echo COMPONENTS=$(find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist -not -wholename '*/Bridge/PhpUnit/*' | xargs -I{} dirname {}) >> $GITHUB_ENV | |
| else | |
| echo COMPONENTS=$(find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist | xargs -I{} dirname {}) >> $GITHUB_ENV | |
| fi | |
| # Legacy tests are skipped when deps=high and when the current branch version has not the same major version number as the next one | |
| [[ "${{ matrix.mode }}" = high-deps && $SYMFONY_VERSION = *.4 ]] && echo LEGACY=,legacy >> $GITHUB_ENV || true | |
| echo SYMFONY_VERSION=$SYMFONY_VERSION >> $GITHUB_ENV | |
| echo COMPOSER_ROOT_VERSION=$SYMFONY_VERSION.x-dev >> $GITHUB_ENV | |
| echo SYMFONY_REQUIRE=">=$([ '${{ matrix.mode }}' = low-deps ] && echo 5.4 || echo $SYMFONY_VERSION)" >> $GITHUB_ENV | |
| [[ "${{ matrix.mode }}" = *-deps ]] && mv composer.json.phpunit composer.json || true | |
| - name: Install dependencies | |
| run: | | |
| echo "::group::composer update" | |
| $COMPOSER_UP | |
| echo "::endgroup::" | |
| echo "::group::install phpunit" | |
| ./phpunit install | |
| echo "::endgroup::" | |
| - name: Patch return types | |
| if: "matrix.php == '8.1' && ! matrix.mode" | |
| run: | | |
| patch -sp1 < .github/expected-missing-return-types.diff | |
| git add . | |
| composer install -q --optimize-autoloader || composer install --optimize-autoloader | |
| SYMFONY_PATCH_TYPE_DECLARATIONS='force=2&php=8.1' php .github/patch-types.php | |
| git checkout src/Symfony/Contracts/Service/ResetInterface.php | |
| SYMFONY_PATCH_TYPE_DECLARATIONS='force=2&php=8.1' php .github/patch-types.php # ensure the script is idempotent | |
| git checkout src/Symfony/Contracts/Service/ResetInterface.php | |
| git diff --exit-code | |
| - name: Check return types | |
| if: "matrix.php == '8.1' && ! matrix.mode" | |
| run: | | |
| php .github/patch-types.php lint | |
| - name: Run tests | |
| run: | | |
| _run_tests() { | |
| local ok=0 | |
| local title="$1$FLIP" | |
| local start=$(date -u +%s) | |
| OUTPUT=$(bash -xc "$2" 2>&1) || ok=1 | |
| local end=$(date -u +%s) | |
| if [[ $ok -ne 0 ]]; then | |
| printf "\n%-70s%10s\n" $title $(($end-$start))s | |
| echo "$OUTPUT" | |
| echo -e "\n::error::KO $title\\n" | |
| else | |
| printf "::group::%-68s%10s\n" $title $(($end-$start))s | |
| echo "$OUTPUT" | |
| echo -e "\n\\e[32mOK\\e[0m $title\\n\\n::endgroup::" | |
| fi | |
| [[ "${{ matrix.mode }}" = experimental ]] || (exit $ok) | |
| } | |
| export -f _run_tests | |
| if [[ ! "${{ matrix.mode }}" = *-deps ]]; then | |
| echo "$COMPONENTS" | xargs -n1 | parallel -j +3 "_run_tests {} '$PHPUNIT {}'" | |
| exit 0 | |
| fi | |
| if [[ "${{ matrix.mode }}" = low-deps ]]; then | |
| echo "$COMPONENTS" | xargs -n1 | parallel -j +3 "_run_tests {} 'cd {} && $COMPOSER_UP --prefer-lowest --prefer-stable && $PHPUNIT'" | |
| exit 0 | |
| fi | |
| (cd src/Symfony/Component/HttpFoundation; cp composer.json composer.bak; composer require --dev --no-update mongodb/mongodb) | |
| (cd src/Symfony/Component/Lock; cp composer.json composer.bak; composer require --dev --no-update mongodb/mongodb) | |
| # matrix.mode = high-deps | |
| echo "$COMPONENTS" | xargs -n1 | parallel -j +3 "_run_tests {} 'cd {} && $COMPOSER_UP && $PHPUNIT$LEGACY'" || X=1 | |
| # get a list of the patched components (relies on .github/build-packages.php being called in the previous step) | |
| (cd src/Symfony/Component/HttpFoundation; mv composer.bak composer.json) | |
| (cd src/Symfony/Component/Lock; mv composer.bak composer.json) | |
| PATCHED_COMPONENTS=$(git diff --name-only src/ | grep composer.json || true) | |
| # for 6.4 LTS, checkout and test previous major with the patched components (only for patched components) | |
| if [[ $PATCHED_COMPONENTS && $SYMFONY_VERSION = 6.4 ]]; then | |
| export FLIP='^' | |
| SYMFONY_VERSION=$(echo $SYMFONY_VERSION | awk '{print $1 - 1}') | |
| echo -e "\\n\\e[33;1mChecking out Symfony $SYMFONY_VERSION and running tests with patched components as deps\\e[0m" | |
| export COMPOSER_ROOT_VERSION=$SYMFONY_VERSION.x-dev | |
| export SYMFONY_REQUIRE=">=$SYMFONY_VERSION" | |
| git fetch --depth=2 origin $SYMFONY_VERSION | |
| git checkout -m FETCH_HEAD | |
| PATCHED_COMPONENTS=$(echo "$PATCHED_COMPONENTS" | xargs dirname | xargs -n1 -I{} bash -c "[ -e '{}/phpunit.xml.dist' ] && echo '{}'" | sort || true) | |
| (cd src/Symfony/Component/HttpFoundation; composer require --dev --no-update mongodb/mongodb) | |
| (cd src/Symfony/Component/Lock; composer require --dev --no-update mongodb/mongodb) | |
| if [[ $PATCHED_COMPONENTS ]]; then | |
| echo "::group::install phpunit" | |
| ./phpunit install | |
| echo "::endgroup::" | |
| echo "$PATCHED_COMPONENTS" | parallel -j +3 "_run_tests {} 'cd {} && rm composer.lock vendor/ -Rf && $COMPOSER_UP && $PHPUNIT$LEGACY'" || X=1 | |
| fi | |
| fi | |
| [[ ! $X ]] || (exit 1) | |
| - name: Run TTY tests | |
| if: "! matrix.mode" | |
| run: | | |
| script -e -c './phpunit --group tty' /dev/null | |
| - name: Run tests with SIGCHLD enabled PHP | |
| if: "matrix.php == '8.1' && ! matrix.mode" | |
| run: | | |
| mkdir build | |
| cd build | |
| wget -q https://github.com/symfony/binary-utils/releases/download/v0.1/php-8.1.2-pcntl-sigchild.tar.bz2 | |
| tar -xjf php-8.1.2-pcntl-sigchild.tar.bz2 | |
| cd .. | |
| mkdir -p /opt/php/lib | |
| echo memory_limit=-1 > /opt/php/lib/php.ini | |
| ./build/php/bin/php ./phpunit --colors=always src/Symfony/Component/Process |