Skip to content

fix history implementation #220

fix history implementation

fix history implementation #220

GitHub Actions / clippy succeeded Sep 27, 2023 in 0s

clippy

8 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 8
Note 0
Help 0

Versions

  • rustc 1.72.1 (d5c2e9c34 2023-09-13)
  • cargo 1.72.1 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (d5c2e9c 2023-09-13)

Annotations

Check warning on line 218 in src/trial/history.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> src/trial/history.rs:218:37
    |
218 |             self.max_misalignment + col as usize
    |                                     ^^^^^^^^^^^^ help: try: `col`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 37 in src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> src/config.rs:33:1
   |
33 | / impl Default for Theme {
34 | |     fn default() -> Self {
35 | |         Self {}
36 | |     }
37 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it
   |
31 + #[derive(Default)]
32 | pub struct Theme {}
   |

Check warning on line 262 in src/trial/history.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `first_grapheme_cluster` is never used

warning: function `first_grapheme_cluster` is never used
   --> src/trial/history.rs:262:4
    |
262 | fn first_grapheme_cluster(string: &str) -> &str {
    |    ^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 60 in src/trial/history.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple associated items are never used

warning: multiple associated items are never used
   --> src/trial/history.rs:60:12
    |
58  | impl History {
    | ------------ associated items in this implementation
59  |     /// Creates a new history, with empty typed and reference strings.
60  |     pub fn new(max_misalignment: usize) -> Self {
    |            ^^^
...
77  |     pub fn push_reference(&mut self, reference: &str) {
    |            ^^^^^^^^^^^^^^
...
125 |     fn push_typed(&mut self, typed: &str) {
    |        ^^^^^^^^^^
...
184 |     const MATCH_COST: u32 = 0;
    |           ^^^^^^^^^^
...
188 |     const MISMATCH_COST: u32 = 2;
    |           ^^^^^^^^^^^^^
189 |     // An insertion or deletion requires one keystroke.
190 |     const INSERTION_COST: u32 = 1;
    |           ^^^^^^^^^^^^^^
191 |     const DELETION_COST: u32 = 1;
    |           ^^^^^^^^^^^^^
192 |
193 |     fn tracked_entries_per_row(&self) -> usize {
    |        ^^^^^^^^^^^^^^^^^^^^^^^
...
197 |     fn row_indices(&self, row: usize) -> impl Iterator<Item = EntryIndices> {
    |        ^^^^^^^^^^^
...
212 |     fn col_indices(&self, col: usize) -> impl Iterator<Item = EntryIndices> {
    |        ^^^^^^^^^^^
...
240 |     fn replacement_cost(&self, row: isize, col: isize) -> Option<u32> {
    |        ^^^^^^^^^^^^^^^^

Check warning on line 41 in src/trial/history.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variants `Match`, `Mismatch`, `Insertion`, `Deletion`, and `Invalid` are never constructed

warning: variants `Match`, `Mismatch`, `Insertion`, `Deletion`, and `Invalid` are never constructed
  --> src/trial/history.rs:41:5
   |
39 | enum NWAction {
   |      -------- variants in this enum
40 |     /// The typed and reference grapheme clusters match.
41 |     Match,
   |     ^^^^^
...
44 |     Mismatch,
   |     ^^^^^^^^
...
48 |     Insertion,
   |     ^^^^^^^^^
...
52 |     Deletion,
   |     ^^^^^^^^
...
55 |     Invalid,
   |     ^^^^^^^
   |
   = note: `NWAction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 6 in src/trial/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct `Trial` is never constructed

warning: struct `Trial` is never constructed
 --> src/trial/mod.rs:6:12
  |
6 | pub struct Trial {
  |            ^^^^^

Check warning on line 39 in src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `deserialize_style` is never used

warning: function `deserialize_style` is never used
  --> src/config.rs:39:4
   |
39 | fn deserialize_style<'de, D>(deserializer: D) -> Result<Style, D::Error>
   |    ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 1 in src/trial/history.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `collections::btree_map::Entry`, `ops::Range`

warning: unused imports: `collections::btree_map::Entry`, `ops::Range`
 --> src/trial/history.rs:1:11
  |
1 | use std::{collections::btree_map::Entry, convert::TryFrom, iter, ops::Range};
  |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                          ^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default