feat(trial): implement grapheme clustered input #320
Annotations
1 error and 33 warnings
Rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/trial/history.rs#L197
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/trial/history.rs:197:37
|
197 | self.max_misalignment + col as usize
| ^^^^^^^^^^^^ help: try: `col`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
this `impl` can be derived:
src/config.rs#L37
warning: this `impl` can be derived
--> src/config.rs:37:1
|
37 | / impl Default for Theme {
38 | | fn default() -> Self {
39 | | Self {}
40 | | }
41 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it
|
35 + #[derive(Default)]
36 | pub struct Theme {}
|
|
function `first_grapheme_cluster` is never used:
src/trial/history.rs#L241
warning: function `first_grapheme_cluster` is never used
--> src/trial/history.rs:241:4
|
241 | fn first_grapheme_cluster(string: &str) -> &str {
| ^^^^^^^^^^^^^^^^^^^^^^
|
struct `EntryIndices` is never constructed:
src/trial/history.rs#L235
warning: struct `EntryIndices` is never constructed
--> src/trial/history.rs:235:8
|
235 | struct EntryIndices {
| ^^^^^^^^^^^^
|
multiple associated items are never used:
src/trial/history.rs#L39
warning: multiple associated items are never used
--> src/trial/history.rs:39:12
|
37 | impl History {
| ------------ associated items in this implementation
38 | /// Creates a new history, with empty typed and reference strings.
39 | pub fn new(max_misalignment: usize) -> Self {
| ^^^
...
56 | pub fn push_reference(&mut self, reference: &str) {
| ^^^^^^^^^^^^^^
...
104 | pub fn push_typed(&mut self, typed: &str) {
| ^^^^^^^^^^
...
163 | const MATCH_COST: u32 = 0;
| ^^^^^^^^^^
...
167 | const MISMATCH_COST: u32 = 2;
| ^^^^^^^^^^^^^
168 | // An insertion or deletion requires one keystroke.
169 | const INSERTION_COST: u32 = 1;
| ^^^^^^^^^^^^^^
170 | const DELETION_COST: u32 = 1;
| ^^^^^^^^^^^^^
171 |
172 | fn tracked_entries_per_row(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^
...
176 | fn row_indices(&self, row: usize) -> impl Iterator<Item = EntryIndices> {
| ^^^^^^^^^^^
...
191 | fn col_indices(&self, col: usize) -> impl Iterator<Item = EntryIndices> {
| ^^^^^^^^^^^
...
219 | fn replacement_cost(&self, row: isize, col: isize) -> Option<u32> {
| ^^^^^^^^^^^^^^^^
|
function `push_to_working_cluster` is never used:
src/trial/mod.rs#L58
warning: function `push_to_working_cluster` is never used
--> src/trial/mod.rs:58:4
|
58 | fn push_to_working_cluster(working_grapheme_cluster: &mut String, scalar: char) -> Option<String> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
associated items `new` and `process` are never used:
src/trial/mod.rs#L29
warning: associated items `new` and `process` are never used
--> src/trial/mod.rs:29:12
|
27 | impl Trial {
| ---------- associated items in this implementation
28 | /// Create a new trial.
29 | pub fn new(env: &crate::Env) -> Self {
| ^^^
...
37 | pub fn process(&mut self, input: Input) {
| ^^^^^^^
|
enum `Input` is never used:
src/trial/mod.rs#L18
warning: enum `Input` is never used
--> src/trial/mod.rs:18:10
|
18 | pub enum Input {
| ^^^^^
|
struct `Trial` is never constructed:
src/trial/mod.rs#L8
warning: struct `Trial` is never constructed
--> src/trial/mod.rs:8:12
|
8 | pub struct Trial {
| ^^^^^
|
function `deserialize_color` is never used:
src/config.rs#L110
warning: function `deserialize_color` is never used
--> src/config.rs:110:4
|
110 | fn deserialize_color<'de, D>(deserializer: D) -> Result<Color, D::Error>
| ^^^^^^^^^^^^^^^^^
|
function `deserialize_style` is never used:
src/config.rs#L43
warning: function `deserialize_style` is never used
--> src/config.rs:43:4
|
43 | fn deserialize_style<'de, D>(deserializer: D) -> Result<Style, D::Error>
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test:
src/trial/mod.rs#L8
struct `Trial` is never constructed
|
Test:
src/trial/mod.rs#L18
enum `Input` is never used
|
Test:
src/trial/mod.rs#L29
associated items `new` and `process` are never used
|
Test
`ttyper` (bin "ttyper" test) generated 3 warnings
|