rc make: support multiline error pattern #5246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ftr |
krobelus
reviewed
Oct 6, 2024
rc/tools/make.kak
Outdated
| @@ -60,7 +60,7 @@ define-command -hidden make-jump %{ | |||
| set-register a "%reg{1}/%reg{2}" "%reg{3}" "%reg{4}" "%reg{5}" | |||
| } catch %{ | |||
| set-register / %opt{make_error_pattern} | |||
| execute-keys <a-h><a-l> s<ret>l | |||
| execute-keys n | |||
There was a problem hiding this comment.
sounds reasonable. I didn't test this but I think this should be something like <a-h><semicolon>n to make sure <ret> keeps working if the cursor is in the middle of an error message.
ygrek
force-pushed
the
make_error_pattern_multiline
branch
from
bab414f
to
2f23cf7
Compare
|
@krobelus i misunderstood what it was doing, now tested with both original and my error pattern, everything seems to work properly, also left comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently this is what is needed to support multiline error message pattern, e.g. for ocaml :
NB jump_current_line highlights only the last line, technically should change to jump_current_selection, not sure if it is ok (compatibilty?)