Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorconfig: allow to disable automatic edition #5190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stacyharper
Copy link
Contributor

No description provided.

@mawww
Copy link
Owner

mawww commented Jun 23, 2024

I am not sure this option is necessary, you can achieve the same thing by disabling the hooks themselves with set global disabled_hooks autowrap|editorconfig-hooks which does not seem much worse than an editorconfig specific option.

@stacyharper
Copy link
Contributor Author

stacyharper commented Jun 23, 2024

I think I could go leaving the trim_trailing_whitespace, because it is a less common option, and because the BufWritePre hook is less intrusive imo.

But enabling auto-wrapping is a problem to me (maybe because I think this module is poorly designed atm, and behave badly most of the time). This should be up to the user to enable this with filetypes they want.

set global disabled_hooks autowrap is a valid work-around, but then the user have to configure each filetypes themselves, when they want it, which go against the goal of editorconfig.

(In a general manner, I would like for Kakoune to not edit files by itself. But I understand your opinion on this might diverge. Autowrapping, whitespace cleanup, or any automatic edition, can cause lot of vcs conflicts on projects we work for.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants