Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc tools menu: replace menu builtin with a prompt-based implementation #5038

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

krobelus
Copy link
Contributor

prompt has fuzzy filtering which is more discoverable than the menu
mode's regex filtering (because that one needs / to trigger it).
There are no important differences left, so replace the menu builtin
with a prompt-based command.

prompt does not support markup in the completion menu, so drop that
feature for now.

prompt has fuzzy filtering which is more discoverable than the menu
mode's regex filtering (because that one needs / to trigger it).
There are no important differences left, so replace the menu builtin
with a prompt-based command.

prompt does not support markup in the completion menu, so drop that
feature for now.
Along -select-cmds this is useful to implement preview functionality.
@mawww mawww merged commit c93c57a into mawww:master Dec 2, 2023
5 of 6 checks passed
@ftonneau
Copy link

ftonneau commented Jun 6, 2024

A comment about a possible downside of the new menu command. I have been refactoring and improving digraphs.kak, a plugin of mine that searches for Vim-like digraphs based on their two-character codes or short descriptions. Looking for LETTER, for example, will return 792 digraph candidates. With menu as a builtin, the menu used to populate instantaneously. With the new implementation, however, I see the "waiting for shell command to finish ..." message for about 3 seconds.

Nothing life-threatening, of course, but annoying to those familiar with the older menu implementation. Plugins written by other authors (I have no specifics in mind) may also involve menus with hundreds of entries, which will require seconds to build.

@krobelus
Copy link
Contributor Author

krobelus commented Jun 6, 2024

yeah that's why I made #5060 and now https://lists.sr.ht/~mawww/kakoune/patches/51802

@krobelus krobelus deleted the fuzzy-menu branch October 27, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants