Move mavlink-dump from src/bin to examples/mavlink-dump #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting the example has the following benefits: - Faster normal compilation for library use - Easier to retain compilation incremental files (faster re-compilation times) - Cleaner library src/ directory - no_std/std definitions and imports can be removed from the mavlink-dump example - Executable name changes from mavlink -> mavlink-dump. More precise to locate and guess what it is for Disadvantage: - Installation time for the example is increased, but it is something rarely done
antonio-sc66
force-pushed
the
feature-split-mavlink-dump
branch
from
c9e6f51
to
fedc55d
Compare
antonio-sc66
force-pushed
the
feature-split-mavlink-dump
branch
from
fedc55d
to
d1e7593
Compare
|
The CI for the mavlink-dump is failing as the call |
antonio-sc66
force-pushed
the
feature-split-mavlink-dump
branch
from
ef0af90
to
436f479
Compare
patrickelectric
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor mavlink-dump. Change from [[bin]] to [[example]].
Splitting the example has the following benefits:
Disadvantage:
When running
cargo run --example mavlink-dumpcompilation time and execution stays the same or better (easier to retain compilation incremental files)Installation output
Empty args execution