TCP sendto removal + error when UDP for hostnames #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UDP inet_pton(remote_ip)'s result is not checked -> the server ends up sending packets to the null address when a hostname is given instead of a IPv4 address. A error is now raised - TCP is using sendto() instead of send(). We can thus remove a useless inet_pton() call (which moreover differs from the gethostbyaddr used in setup_port() - possible issues when using hostnames) Signed-off-by: Benoit Maurin <[email protected]>
|
|
Investigating error on macos: F inet_ntoa on FreeBSD - not threadsafe (https://opensource.apple.com/source/Libc/Libc-391/net/FreeBSD/inet_ntoa.c.auto.html) |
|
Feel free to make another PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDP inet_pton(remote_ip)'s result is not checked -> the server ends up sending packets to the null address when a hostname is given instead of a IPv4 address. A error is now raised
TCP is using sendto() instead of send(). We can thus remove a useless inet_pton() call (which moreover differs from the gethostbyaddr used in setup_port() - possible issues when using hostnames)
Before the change:
After: