Update gimbal.cpp #2387
Merged
Update gimbal.cpp #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KarthiAru
commented
Aug 29, 2024
KarthiAru
commented
- Added gimbal_id param to all the gimbal methods
- Updated yaw values to point to NESW directions
- Added gimbal_id param to all the gimbal methods - Updated yaw values to point to NESW directions
Minor fix
JonasVautherin
previously approved these changes
Aug 29, 2024
JonasVautherin
previously approved these changes
Aug 29, 2024
julianoes
previously approved these changes
Aug 29, 2024
| if (gimbal_result != Gimbal::Result::Success) { | ||
| std::cerr << "Could not take gimbal control: " << gimbal_result << '\n'; | ||
| return 1; | ||
| } | ||
|
|
||
| // Fetch the gimbal attitude | ||
| auto [result, attitude] = gimbal.get_attitude(gimbal_id); |
Removed sleep after gimbal.take_control
KarthiAru
dismissed stale reviews from julianoes and JonasVautherin
via
c9c1c2a
|
julianoes
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.