Fix battery voltage, included extended voltages #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specs" This reverts commit a8737b9. Signed-off-by: Julian Oes <[email protected]>
Otherwise, the overall voltage is wrong. Signed-off-by: Julian Oes <[email protected]>
JonasVautherin
approved these changes
Aug 14, 2023
|
I don't know where you got the 255 for. The array we iterate over is only 10 entries long. |
|
I don't know, I just see now that it is there in the code 🤣. Good for me then! |
This was referenced Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.