Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize url.Values when building RO db pool #3

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Initialize url.Values when building RO db pool #3

merged 1 commit into from
Jan 11, 2024

Conversation

hifi
Copy link
Member

@hifi hifi commented Jan 11, 2024

No description provided.

tulir
tulir approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That strings.Split (which was already there) is a bit sus, should probably be url.Parse instead 🤔

@hifi
Copy link
Member Author

hifi commented Jan 11, 2024

Yeah, that was some quick hack we used before and it got ported to utils.

@hifi hifi merged commit d055a64 into main Jan 11, 2024
6 checks passed
@hifi hifi deleted the fix/ro-db-pool-init branch January 11, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hifi @tulir