-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
social login guide #338
social login guide #338
Conversation
Hi, @RitaOC good job on this. I have fixed some of the formatting issues myself. @RCheesley or @favour-chibueze will take a look. Thanks 🙏 |
Thanks so much @fakela, awaiting response from @RCheesley or @favour-chibueze |
@RitaOC please can you follow the instructions for using link macros as below (copied from another issue):
Please also use the following header syntax:
I've marked it as accepted due to the deadline but these need addressing before we can consider it for merging. |
Thanks so much @RCheesley, I've worked on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RitaOC thanks for making this PR!
There are a lot of things that you missed because Vale was turned off right at the start, and turned on right at the end ... that's cheating! 🤣
I've suggested fixes for all the incorrect nested headings, and also for many of the Vale issues that were reported. Please take a look and address as you see fit.
Thanks!
Ohh I actually met the Vale written as such in the document, never knew it was wrong but I'd be sure to remove the both lines that speaks to that, I'd also work on all other issues raised and revert back. Thanks for your patience @RCheesley |
To sort the vale removal, heading and formatting issues Co-authored-by: Ruth Cheesley <[email protected]>
To sort vale removal & heading issue Co-authored-by: Ruth Cheesley <[email protected]>
Hi @RCheesley, I've resolved all the issues raised, kindly go through it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go - the build failure is due to Maxmind blocking the agent that checks the links (we will need a PR to add it to the ignored URLs for the checker) and the warnings are not needing to be addressed as the words are being used in a different context.
Thanks for the hard work @RitaOC 🚀
Thanks so much for your direction on this, glad I could wrap it up till the end. |
No description provided.