Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding link where to find the SF configuration docs #315

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Adding link where to find the SF configuration docs #315

merged 5 commits into from
Oct 11, 2024

Conversation

escopecz
Copy link
Member

@escopecz escopecz commented Sep 6, 2024

No description provided.

RCheesley
RCheesley requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typo fixes and also a request to create the link file.

docs/plugins/salesforce.rst Outdated Show resolved Hide resolved
@escopecz escopecz requested a review from RCheesley October 11, 2024 13:38
RCheesley
RCheesley requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion.

@escopecz escopecz requested a review from RCheesley October 11, 2024 13:44
RCheesley
RCheesley approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - you actually don't have to make the name and the text shown the same, they can be different - but this works!

@RCheesley RCheesley merged commit 8a0e422 into 5.x Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escopecz @RCheesley