Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new command reference #10775 #289

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Add new command reference #10775 #289

merged 5 commits into from
Jun 13, 2024

Conversation

RCheesley
Copy link
Member

Adds details for new command to analyze custom fields for the purpose of optimization.

Ref mautic/mautic#10775.

@RCheesley RCheesley requested review from shinde-rahul and a team April 16, 2024 16:30
@RCheesley RCheesley mentioned this pull request Apr 16, 2024
Merged
@RCheesley RCheesley added this to the Mautic 5.1 milestone Apr 16, 2024
escopecz
escopecz previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Ruth! This is correct 👍

It may be worth saying that this way users can optimize the VARCHAR columns so they could create more custom fields if they hit the hard limit on the leads table and cannot create more.

@RCheesley
Copy link
Member Author

It may be worth saying that this way users can optimize the VARCHAR columns so they could create more custom fields if they hit the hard limit on the leads table and cannot create more.

Please check the latest commit - I added some clarifying text on this. Thanks for the review!

escopecz
escopecz previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 👍

@RCheesley RCheesley merged commit 3264ba2 into mautic:5.x Jun 13, 2024
2 checks passed
@RCheesley RCheesley deleted the 10775 branch June 13, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz left review comments

@shinde-rahul shinde-rahul Awaiting requested review from shinde-rahul

Assignees
No one assigned
Labels
ready-to-commit
Projects
None yet
Milestone
Mautic 5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@RCheesley @escopecz