-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progressive profiling section #257
Conversation
Signed-off-by: Priyanshi Gaur <[email protected]>
@nox1134 please take note of the feedback from Vale and let us know if you need any help with fixing the issues it's flagged up! |
Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
@RCheesley, I have fixed the vale errors now. Could you please review the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still quite a few Vale fixes to do, I've suggested how to convert these to active tense as it's not always easy!
Signed-off-by: Priyanshi Gaur <[email protected]>
So sorry @nox1134 you're right about the Form Fields being capitalised! 🤦 |
Signed-off-by: Priyanshi Gaur <[email protected]>
No worries @RCheesley! I have capitalised the form fields. Are there any other changes ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG, thanks for the PR @nox1134 🚀
Fixes: #230 by @RCheesley
The Progressive Profiling section (https://github.com/mautic/mautic-documentation/blob/main/pages/11.Components/03.Forms/02.Progressive%20Profiling/docs.en.md) is missing from the documentation.
This PR resolves the issue by adding the Progressive Profiling section to the Components/Forms page.