Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressive profiling section #257

Merged
merged 13 commits into from
May 1, 2024
Merged

Add progressive profiling section #257

merged 13 commits into from
May 1, 2024

Conversation

nox1134
Copy link
Member

@nox1134 nox1134 commented Mar 15, 2024

Fixes: #230 by @RCheesley

The Progressive Profiling section (https://github.com/mautic/mautic-documentation/blob/main/pages/11.Components/03.Forms/02.Progressive%20Profiling/docs.en.md) is missing from the documentation.
This PR resolves the issue by adding the Progressive Profiling section to the Components/Forms page.

Screenshot 2024-03-15 at 10 30 43 PM

@RCheesley
Copy link
Member

@nox1134 please take note of the feedback from Vale and let us know if you need any help with fixing the issues it's flagged up!

RCheesley and others added 9 commits April 16, 2024 17:41
@nox1134
Copy link
Member Author

nox1134 commented Apr 22, 2024

@RCheesley, I have fixed the vale errors now. Could you please review the PR?

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still quite a few Vale fixes to do, I've suggested how to convert these to active tense as it's not always easy!

docs/components/forms.rst Show resolved Hide resolved
docs/components/forms.rst Show resolved Hide resolved
docs/components/forms.rst Outdated Show resolved Hide resolved
docs/components/forms.rst Outdated Show resolved Hide resolved
docs/components/forms.rst Outdated Show resolved Hide resolved
docs/components/forms.rst Outdated Show resolved Hide resolved
docs/components/forms.rst Outdated Show resolved Hide resolved
@nox1134 nox1134 requested a review from RCheesley April 23, 2024 20:50
@RCheesley
Copy link
Member

So sorry @nox1134 you're right about the Form Fields being capitalised! 🤦

Signed-off-by: Priyanshi Gaur <[email protected]>
@nox1134
Copy link
Member Author

nox1134 commented Apr 24, 2024

No worries @RCheesley! I have capitalised the form fields. Are there any other changes ?

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG, thanks for the PR @nox1134 🚀

@RCheesley RCheesley merged commit a33d0d9 into mautic:5.x May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add progressive profiling section
2 participants