Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authentication.rst #197

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Update authentication.rst #197

merged 11 commits into from
Sep 21, 2023

Conversation

Amiyah14
Copy link
Contributor

@Amiyah14 Amiyah14 commented Aug 28, 2023

Added correct configuration for Azure SAML SSO

Added correct configuration for Azure SAML SSO
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Amiyah14 thanks for making the PR!

A couple of things which I've suggested changes for:

  • We use RST rather than pure markdown on Read the Docs, so I've fixed the headings and added the extra backtick (inline code requires two at the start and end, rather than one)
  • We use example.com in place of the domain where your Mautic instance lies
  • Small suggestions by Vale

Hopefully all quick fixes!

docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
docs/authentication/authentication.rst Outdated Show resolved Hide resolved
@RCheesley
Copy link
Member

@all-contributors please add @Amiyah14 for docs

@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @Amiyah14! 🎉

@Amiyah14 Amiyah14 requested a review from RCheesley September 5, 2023 19:32
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR! 🚀

@RCheesley RCheesley merged commit 25c7fbc into mautic:main Sep 21, 2023
2 checks passed
@Amiyah14 Amiyah14 deleted the patch-1 branch July 21, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants