Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shortener services #191

Merged
merged 13 commits into from
Jan 9, 2024

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jul 28, 2023

@kuzmany kuzmany changed the title Rename .readthedocs.yaml to readthedocs.yaml Add support for shortener services Jul 28, 2023
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing the docs for this @kuzmany - some suggested changes based on our style guide. Let me know if you need any help with any of it!

docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
@RCheesley
Copy link
Member

@kuzmany this needs rebasing onto 5.x please, and the suggestions addressing. Thanks!

@RCheesley RCheesley changed the base branch from main to 5.x January 9, 2024 18:29
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - some changes required.

docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
@RCheesley
Copy link
Member

GTG! 🚀

@RCheesley RCheesley merged commit 112d11f into mautic:5.x Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants