Added exceptions to invalid Mautic ID

mautic · Aug 3, 2017 · 6ee4cfa · 6ee4cfa
1 parent 3edf2fc
commit 6ee4cfa
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Classes/Domain/Finishers/MauticFinisher.php b/Classes/Domain/Finishers/MauticFinisher.php
@@ -53,14 +53,18 @@ protected function executeInternal()
             return;
         }
 
-        if (!empty($mauticId)) {
+        if (!empty($mauticId) && is_numeric($mauticId)) {
 
             // Get the values that were posted in the form and transform them to a format for Mautic
             $formValues = $this->transformFormStructure($this->finisherContext->getFormValues());
 
             $this->mauticService->pushForm($formValues, $this->mauticService->getConfigurationData('mauticUrl'), $mauticId);
         } else {
-            \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump('not meeting requirements for finisher mautic', 'ExecuteInternal');
+            if (GeneralUtility::getApplicationContext()->isDevelopment()) {
+                throw new \InvalidArgumentException('Your YAML does not appear to contain a valid Mautic Form ID.', 1499940157);
+            }
+
+            return;
         }
     }