spotify: handle MP3_160_ENC #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add lib/crypto.js: handles all key generation and decryption functionality modify lib/spotify.js: handles sneaky `album_art` messages modify lib/track.js: `play` now includes decryption transformer in pipeline modify lib/util.js: added hex2bin and bin2hex helper functions modify package.json: commit changes require newer `superagent`
ghost
referenced
this pull request
in Shigawire/node-spotify-web
Apr 30, 2016
removes the dependency on http://git.io/WyCx0Q
| } else if ('album_art' == command) { | ||
| var js = args[0][1]; | ||
| try { | ||
| vm.runInContext("window = {eval: eval}; " + js, this._context); |
There was a problem hiding this comment.
Now, this is some album art I can get behind!
modify package.json: remove references to `protobuf` modify lib/schemas.js: remove references to `protobuf`, make `protobufjs` the only parser remove proto/*.desc: only required for the `protobuf` module
So as it turns out, the old code seems to have taken the very first "album_art" message over to every single track that followed, if an Album or Playlist was fetched. This code basically runs it through a new Context within the code-execution VM every time one of those messages is being received.
Fix for trying to fetch a whole album / playlist at once. Fix library method not being able to fetch saved tracks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add lib/crypto.js: handles all key generation and decryption functionality
modify lib/spotify.js: handles sneaky
album_artmessagesmodify lib/track.js:
playnow includes decryption transformer in pipelinemodify lib/util.js: added hex2bin and bin2hex helper functions
modify package.json: commit changes require newer
superagent