-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Source Maps with Sections #11
Open
rokob
wants to merge
12
commits into
mattrobenolt:master
Choose a base branch
from
rollbar:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4 lookup back to the enumeration
…ernals of this library
add support for sectioned source maps
Hi @rollbar. |
hi @mattrobenolt ! :) |
Add pull request template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
decode
now returns eitherSourceMapIndex
orSectionedSourceMapIndex
depending on whether the input has a'sections'
key.SectionedSourceMapIndex
implements the same interface asSourceMapIndex
allowing for the external interaction to be transparent to which type of index is returnedlookup
now returns both a token and theSourceMapIndex
the token came from. This is relevant for working with the index around the token especially withSectionedSourceMapIndex
as the lookup fromSourceMapIndex
just returnsself
.Additional API methods were created to make it easier to work with the underlying index without having to reach into the internals: