preupdate_hook: move convertAssign code to preupdate_hook file #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
reviewed
Oct 17, 2023
That's also a valid solution. My motivation for moving it to sqlite3_opt_preupdate_hook.go is that it is a relatively small file, it's nice to consolidate logic, and most of the file names match their respective build tags so I felt that it would be clearer / more consistent to move it there. |
Move the convertAssign logic from convert.go to sqlite3_opt_preupdate_hook.go since that is the only place it is used.
charlievieth
force-pushed
the
cev/convertassign
branch
from
739144e
to
0ab9673
Compare
|
@dolmen could you take another look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the convertAssign logic from convert.go to
sqlite3_opt_preupdate_hook.go since that is the
only place it is used.