-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare author against id instead of 'me' #116
base: master
Are you sure you want to change the base?
Conversation
I think we should keep backward compatibility and release this feature. At the moment I don't have that many active collaborators to be able to start working on a version 3. I will definitely organize the issues and assess what needs to be included and when would be a right moment to start working on v3. Thanks for this PR and let me know if you can take care of the backward compatibility. Cheers. |
Hi, |
An easy fix for backwards compatibility would be to add a default value?
This is a great feature and would help us quite a bit. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Will be tackled in #194 thanks for the idea :) 👍 |
@mattmezza I think we should include this as a separate thing as it'll be much quicker than tackling that huge PR (and it will make #194 simpler, too, I think). The |
If backward-compability is needed then we gotta do some checks and make
authorID
not required. Right now there is new prop needed,authorId
which is current user id.