Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-37379] Add "Clear Data" options in the menu to allow users to force Electron to blow away session data. #3185

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

devinbinnie
Copy link
Member

Summary

A common problem that seems to happen when users upgrade their Desktop App is that when the new app loads, they can't access their server and it appears to be stuck at a white screen. The only solution we've found to this is to have the user manually reset their app by removing their config and app data folder.

We haven't been able to exactly reproduce this issue, but the feeling is that it's likely to do with some session or cache data being corrupted during the upgrade process. However, since we can't reproduce it, I'm not able to exactly pinpoint where the issue is and to fix it exactly.

So instead, this PR adds two menu options: Clear Data for Current Server and Clear All Data. These options will force the session to clear its data for either a single server, or clear for all, which shouldn't hopefully be an easier, in-app way that does not force the user to reconfigure their application/servers and should still help alleviate this problem.

It's possible this might not end up doing anything - as we know Clear Cache and Reload doesn't work, but this is the next step to forcing the app to blow out session data that is likely the culprit here.

Ticket Link

https://mattermost.atlassian.net/browse/MM-37379

Screenshots

image
image

Added two menu items to help users forcibly clear out cache and session data.

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Oct 25, 2024
@devinbinnie devinbinnie added this to the v5.11.0 milestone Oct 25, 2024
@devinbinnie devinbinnie requested review from svelle, a team, enahum and hanzei and removed request for a team October 25, 2024 18:15
@devinbinnie devinbinnie removed the request for review from enahum October 25, 2024 18:15
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I love seeing more debugging tool for the desktop app 🚀

@svelle svelle added the Build Apps for PR Builds signed builds for testing label Nov 15, 2024
@devinbinnie devinbinnie removed the Build Apps for PR Builds signed builds for testing label Nov 26, 2024
@devinbinnie
Copy link
Member Author

/update-branch

@devinbinnie devinbinnie added the Build Apps for PR Builds signed builds for testing label Nov 26, 2024
Copy link
Member

@svelle svelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think this is a great addition.

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 26, 2024
@devinbinnie devinbinnie enabled auto-merge (squash) November 26, 2024 15:00
@devinbinnie devinbinnie merged commit 723fda8 into master Nov 26, 2024
27 of 28 checks passed
@devinbinnie devinbinnie deleted the MM-37379 branch November 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Builds signed builds for testing release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants