GH-262 - fix issue gui unresponsive when adding a todo #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvev
commented
Nov 11, 2024
| }; | ||
| } | ||
|
|
||
| static getDerivedStateFromProps(props, state) { | ||
| if (state.isTyping) { |
There was a problem hiding this comment.
every type stroke rerenders the component and causes messages to get the props value. This change tracks when the user is typing and will avoid this situation from happening.
|
@Kshitij-Katiyar Can you please take a look? |
@hanzei Do we need to review this PR or something else? |
|
Yes, please review the PR |
Kshitij-Katiyar
approved these changes
Dec 18, 2024
@hanzei Looks good to me |
Kshitij-Katiyar
force-pushed
the
fix-issue-262-gui-unresponsive
branch
from
8f8aa57 to
8892ad4
Compare
hanzei
added
4: Reviews Complete
panoramix360
pushed a commit
to panoramix360/mattermost-plugin-todo
that referenced
this pull request
Jan 14, 2025
… todo (mattermost-community#265) Co-authored-by: Ben Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #262
Before:
Screen.Recording.2024-11-10.at.19.01.43.mov
After:
Screen.Recording.2024-11-10.at.19.00.08.mov