feat(prover): Update witness generator to zkevm_test_harness 0.150.6 #3029
Conversation
| @@ -470,6 +470,7 @@ impl Keystore { | |||
| } | |||
|
|
|||
| /// Async loads mapping of all circuits to setup key, if successful | |||
| #[cfg(feature = "gpu")] | |||
There was a problem hiding this comment.
Huh, was this a miss on my end?
| let artifacts_receiver_handle = thread::spawn(move || { | ||
| let span = tracing::info_span!(parent: make_circuits_span_copy, "make_circuits_blocking"); | ||
|
|
||
| while let Ok(artifact) = artifacts_receiver.recv() { |
There was a problem hiding this comment.
This looks fine, but shouldn't we do something if we can't receive? Maybe log the error?
There was a problem hiding this comment.
Seems like we can have only RecvError, which occurs if the sender is disconnected. This is the expected state after test_harness has finished its work, I don't think we want to log this.
This process will happen in two steps: in the first step (this PR) we simply fill unnecessary fields with zeros to maintain backward compatibility. The next step is to change the input structures of the circuits, from which we will remove unnecessary fields. We will do this during the protocol update.
Yes. But we need to update Shivini, which is part of another monorepo, so that the prover can be compiled in CI
I'm not sure about it. I'll check, but at this stage it shouldn't affect it in any way. |
What ❔
Why ❔
Checklist
zk_supervisor fmtandzk_supervisor lint.