Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test solution #6

Merged
merged 41 commits into from
Aug 29, 2023
Merged

chore: test solution #6

merged 41 commits into from
Aug 29, 2023

Conversation

abilevych
Copy link
Contributor

@abilevych abilevych commented Aug 25, 2023 •
edited
Loading

What 💻

  • created an infrastructure for tests
  • optimized the test code related to Hello World scenario
  • integrated the CI/CD test execution per commit with the era-test-node

Why ✋

  • integration test checks per PR

@abilevych abilevych requested a review from idea404 as a code owner August 25, 2023 13:51
idea404
idea404 suggested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks, a good starting point

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
hello-world/test/main.test.ts Show resolved Hide resolved
@abilevych
Copy link
Contributor Author

Some remarks, a good starting point

Hey @idea404,

thank you for your attention and the comments. I'll let you know once the PR is ready for review (it still is not ready for that).

Considering there are some issues with the era-test-node running, I need to fix them to check how it really works on the CI.

@abilevych
Copy link
Contributor Author

@idea404 It's ready for a review. Could you please take a look at the PR?

@abilevych abilevych requested a review from idea404 August 28, 2023 13:37
idea404
idea404 suggested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions

.github/workflows/tests.yml Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
abilevych and others added 2 commits August 29, 2023 16:48
@idea404 idea404 merged commit 8a13812 into matter-labs:main Aug 29, 2023
@abilevych abilevych deleted the UEXP-4353-test-solution branch August 29, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMER88795 AMER88795 AMER88795 left review comments

@idea404 idea404 idea404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abilevych @idea404 @AMER88795