Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move zk tests to different files #775

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Dec 10, 2024

What 💻

  • Move zk tests to different files

Why ✋

  • Avoid merge conflicts in upstream merges

@Jrigada Jrigada requested a review from a team as a code owner December 10, 2024 18:24
@Jrigada Jrigada changed the base branch from main to fix-jrigada-add-zkout-to-gitignore December 10, 2024 18:24
Karrq
Karrq previously approved these changes Dec 10, 2024
elfedy
elfedy previously approved these changes Dec 10, 2024
Copy link
Contributor

@elfedy elfedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Base automatically changed from fix-jrigada-add-zkout-to-gitignore to main December 10, 2024 20:50
@Jrigada Jrigada dismissed stale reviews from elfedy and Karrq December 10, 2024 20:50

The base branch was changed.

@Jrigada Jrigada requested review from elfedy and Karrq December 10, 2024 20:50
Karrq
Karrq previously approved these changes Dec 11, 2024
@Jrigada Jrigada merged commit e7390e0 into main Dec 13, 2024
21 checks passed
@Jrigada Jrigada deleted the chore-jrigada-move-zk-tests-to-different-files branch December 13, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants