feat: add the ability to use specific gas params in era vm environment and use them on script estimations #773
+625
−467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
requested changes
Dec 11, 2024
nbaztec
reviewed
Dec 13, 2024
crates/zksync/core/src/vm/env.rs
Outdated
| /// Compute gas per pubdata | ||
| pub fn gas_per_pubdata(&self) -> u64 { | ||
| // https://github.com/matter-labs/era-contracts/blob/aafee035db892689df3f7afe4b89fd6467a39313/system-contracts/bootloader/bootloader.yul#L86 | ||
| let max_l2_gas_per_pubdata: u64 = 50000; |
There was a problem hiding this comment.
We can hoist this as a constant
nbaztec
reviewed
Dec 13, 2024
crates/zksync/core/src/utils.rs
Outdated
| @@ -131,5 +131,5 @@ pub fn fix_l2_gas_limit( | |||
| U256::min(proposed_gas_limit, max_gas_limit) | |||
| }; | |||
|
|
|||
| U256::min(gas_limit, U256::from(u32::MAX >> 1)) | |||
| U256::min(gas_limit, U256::from((u32::MAX >> 1) * 2)) | |||
There was a problem hiding this comment.
Perhaps this should also be a constant as it's being used in multiple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
ZkEnvthat contains values to be used when instantiating Era Vm locally.L1PeggedBatchFeeModelInputtoPubdataIndependentBatchFeeModelInput(previous was legacy, era_test_node/testnet/mainnet use the new model)fair_pubdata_priceand makes txs with big factory deps revert via OOG).ZkEnvfor running the script and the simulations.Why ✋
This adds a stepping stone to make gas simulation on era vm txs meaningful by using the actual values from the enviroment the script will be finally broadcast to. This also opens the door for a follow up PR to let users modify these params the same way they can modify EVM env params when running tests.
Evidence 📷
When simulating, simulation now uses
fair_l2_gas_price,l1_gas_priceandfair_pubdata_pricefrom the environment.