Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encode correctly paymaster input #757

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Dec 2, 2024

What 💻

  • With the removal of zksync-web3-rs crate the way clap was treating the incoming paymaster input was leading to an error encoding the bytes.

@Jrigada Jrigada requested a review from a team as a code owner December 2, 2024 12:27
@Jrigada Jrigada linked an issue Dec 2, 2024 that may be closed by this pull request
2 tasks
nbaztec
nbaztec previously approved these changes Dec 2, 2024
Copy link
Collaborator

@nbaztec nbaztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to have a test?

elfedy
elfedy previously approved these changes Dec 3, 2024
@Jrigada Jrigada merged commit 2b973e1 into main Dec 4, 2024
12 checks passed
@Jrigada Jrigada deleted the fix-jrigada-paymaster-error-encoding-input branch December 4, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"failed pre-paymaster preparation" when running forge create with paymaster
4 participants