Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable Foundry tests #746

Merged
merged 19 commits into from
Dec 4, 2024
Merged

chore: Enable Foundry tests #746

merged 19 commits into from
Dec 4, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Nov 26, 2024 •
edited
Loading

What 💻

  • This PR integrates and enables the Foundry test suite to ensure comprehensive testing of the codebase.

Why ✋

  • To increase robustness and reliability of the project by leveraging Foundry's testing capabilities.
  • To validate new code contributions while ensuring that existing functionality remains intact.

@Jrigada Jrigada marked this pull request as ready for review November 27, 2024 14:11
@Jrigada Jrigada requested a review from a team as a code owner November 27, 2024 14:11
Karrq
Karrq previously approved these changes Nov 27, 2024
View reviewed changes
crates/cast/bin/main.rs Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Show resolved Hide resolved
crates/forge/tests/it/test_helpers.rs Show resolved Hide resolved
crates/test-utils/src/util.rs Outdated Show resolved Hide resolved
@Jrigada Jrigada requested a review from nbaztec December 2, 2024 18:07
nbaztec
nbaztec reviewed Dec 3, 2024
View reviewed changes
crates/cast/bin/main.rs Outdated Show resolved Hide resolved
@Jrigada Jrigada requested review from nbaztec and Karrq December 3, 2024 17:52
elfedy
elfedy previously approved these changes Dec 3, 2024
View reviewed changes
.github/scripts/matrices.py Outdated Show resolved Hide resolved
crates/config/src/lib.rs Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Show resolved Hide resolved
Karrq
Karrq previously approved these changes Dec 3, 2024
View reviewed changes
@Jrigada @elfedy
Update .github/scripts/matrices.py
9970caa 
Co-authored-by: Federico Rodríguez <[email protected]>
@Jrigada Jrigada dismissed stale reviews from Karrq and elfedy via 9970caa December 4, 2024 13:08
@Jrigada Jrigada requested review from elfedy and Karrq December 4, 2024 13:10
@Jrigada Jrigada merged commit 0dcc03e into main Dec 4, 2024
22 checks passed
@Jrigada Jrigada deleted the chore/foundry-tests branch December 4, 2024 14:43
@Karrq Karrq mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfedy elfedy elfedy approved these changes

@Karrq Karrq Karrq approved these changes

@nbaztec nbaztec Awaiting requested review from nbaztec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jrigada @nbaztec @Karrq @elfedy