Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add paymaster support to cast send #612

Merged
merged 8 commits into from
Oct 22, 2024
Merged

feat: Add paymaster support to cast send #612

merged 8 commits into from
Oct 22, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Oct 16, 2024 •
edited
Loading

Motivation

There was no way to use cast send command using paymaster

Solution

Added the paymaster parameters to cast send

@Jrigada Jrigada requested a review from Karrq October 16, 2024 15:36
Karrq
Karrq requested changes Oct 16, 2024
View reviewed changes
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
Karrq
Karrq reviewed Oct 17, 2024
View reviewed changes
crates/cast/bin/cmd/send.rs Show resolved Hide resolved
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
@Jrigada Jrigada requested review from Karrq and nbaztec October 18, 2024 13:13
nbaztec
nbaztec previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@nbaztec nbaztec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test, if possible. And update the book.

Karrq
Karrq previously approved these changes Oct 18, 2024
View reviewed changes
@dutterbutter
Copy link
Collaborator

@Jrigada please address merge conflict

@Jrigada Jrigada dismissed stale reviews from Karrq and nbaztec via e5ae334 October 22, 2024 10:25
@Jrigada Jrigada requested a review from a team as a code owner October 22, 2024 10:25
Karrq
Karrq previously approved these changes Oct 22, 2024
View reviewed changes
@Jrigada Jrigada requested review from Karrq and nbaztec October 22, 2024 17:22
@Jrigada Jrigada merged commit baee07e into main Oct 22, 2024
12 checks passed
@Jrigada Jrigada deleted the jrigada-paymaster-in-cast-send branch October 22, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karrq Karrq Karrq approved these changes

@nbaztec nbaztec Awaiting requested review from nbaztec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jrigada @dutterbutter @nbaztec @Karrq