Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update revm, fix env update for deployed contracts and era-test-node #139

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Nov 8, 2023

What 💻

  • Updates revm to latest revision
  • Sets env defaults for env.block.number and env.block.timestamp to 0 as this is what era-test-node starts with
  • Fix env update when deploying contracts
  • Show solc output when compilation fails

Why ✋

  • Required to run zkforge test

Evidence 📷

image

Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please address the CI failures.

@dutterbutter dutterbutter self-requested a review November 8, 2023 16:42
@nbaztec nbaztec merged commit bedd722 into main Nov 8, 2023
9 checks passed
@nbaztec nbaztec deleted the nish-fix-test branch November 8, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants