chore: moves zk_solc.rs and zksolc_manager.rs to common crate
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix-script-cmd-with-zksolc
dutterbutter
added a commit
that referenced
this pull request
Nov 9, 2023
Deniallugo
pushed a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
zk_solc.rsandzksolc_manager.rsto common cratedeny.tomlWhy ✋
commoncrate so it can be accessible to other crates. This aligns withcompile.rswhich handles the EVM compilation in common crate.In addition, this will make adding compile step to
scriptsubcommand easier.opensslfromdeny.tomlas its a dep of era-test-node currently. Will need to clarify with foundry team why is was added to the ban list.Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended