feat(EVM-emulator): add all unused opcodes #836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds all unused opcodes.
Why ❔
Since opcodes are 8-bit long and if we implement all cases in the switch of that range (0-255), LLVM will optimize out default case (as it is shown here where for default case will generate unreachable BB), thus will remove checks before jump table instruction. As a result, this will remove 1 instruction that is executed in a loop header for each opcode.
Before this patch, we had following assembly generated in a loop header:
After this patch:
Checklist