-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update zksolc for system contracts #830
base: dev
Are you sure you want to change the base?
Conversation
const COMPILER_VERSION = "1.5.0"; | ||
const PRE_RELEASE_VERSION = "prerelease-a167aa3-code4rena"; | ||
const COMPILER_VERSION = "fix-output-directory"; // 1.5.5 | ||
const PRE_RELEASE_VERSION = "72ea6d2"; | ||
function getZksolcUrl(): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this getZksolcUrl
thing was needed before when the prerelease version had not yet been published, now we can remove it, could you please switch to just providing version number in hardhat config ts? similarly to how it is done in l2-contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StanislavBreadless we are using the pre-release version in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prerelease fixes a bug with --output-dir
Several of |
What ❔
Why ❔
Checklist