fix: l2-native-token, bridge fixes #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelemeno
requested review from
vladbochok and
StanislavBreadless
as code owners
kelemeno
commented
Sep 19, 2024
…contracts into kl/l2-native-token
kelemeno
changed the base branch from
kl/sync-layer-reorg
to
sync-layer-stable
kelemeno
changed the base branch from
sync-layer-stable
to
kl/sync-layer-reorg
kelemeno
changed the base branch from
kl/sync-layer-reorg
to
sync-layer-stable
Changes to gas cost
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
…led deposits for bridged tokens, add forwarding function to L1AR for SDK
…-contracts into ra/l2-native
fix: Ra/l2 native
kelemeno
commented
Oct 4, 2024
kelemeno
commented
Oct 4, 2024
| @@ -153,6 +150,11 @@ contract L2AssetRouter is AssetRouterBase, IL2AssetRouter { | |||
| } | |||
|
|
|||
| function withdrawToken(address _l2NativeToken, bytes memory _assetData) public returns (bytes32) { | |||
| bytes32 recordedAssetId = INativeTokenVault(L2_NATIVE_TOKEN_VAULT_ADDR).assetId(_l2NativeToken); | |||
| bytes32 recordedOriginChainId = INativeTokenVault(L2_NATIVE_TOKEN_VAULT_ADDR).originChainId(recordedAssetId); | |||
| if (recordedOriginChainId == L1_CHAIN_ID) { | |||
There was a problem hiding this comment.
I am not sure this is correct, the more correct check is to have != block.chainid check
There was a problem hiding this comment.
No, because we will probably want to withdraw tokens that are native to other L2s, and those will be encoded using the new format
There was a problem hiding this comment.
We could use the simple withdraw() for them, but this is also ok I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist