State transition manager test coverage #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neotheprogramist
requested review from
vladbochok and
StanislavBreadless
as code owners
vladbochok
reviewed
May 29, 2024
...cts/test/foundry/unit/concrete/state-transition/StateTransitionManager/AdminManagement.t.sol
Outdated
Show resolved
Hide resolved
...ntracts/test/foundry/unit/concrete/state-transition/StateTransitionManager/FreezeChain.t.sol
Outdated
Show resolved
Hide resolved
Comment on lines
82
to
83
| vm.stopPrank(); | ||
| vm.startPrank(governor); |
There was a problem hiding this comment.
Why do you use this pattern?
There was a problem hiding this comment.
I used this pattern because I did not want to interfere with the tests that were previously created by someone else. However, I made a small modification and now it should be fine.
tejks
force-pushed
the
test/state-transition-manager
branch
from
c187ac3
to
ac523cf
Compare
tommysr
force-pushed
the
test/state-transition-manager
branch
from
ac523cf
to
aa89a96
Compare
tommysr
force-pushed
the
test/state-transition-manager
branch
from
1b9277c
to
2a02804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR enhances the test coverage for the
StateTransitionManagercontract. Specifically, it includes additional unit tests to cover edge cases and scenarios that were previously untested.