This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
WitnessVec is abstract over Allocator #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitima
changed the title
shamatar
approved these changes
Dec 13, 2023
saitima
force-pushed
the
witness-vec-with-allocator
branch
from
e4f5427 to
3bac890
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
WitnessVec is abstract over Allocator and GoodAllocator is 'static
Why ❔
In case witness gen and gpu-proving process are on the different machines we want to speedup data transfer between host and gpu device by placing data to the statically allocated pinned buffer. So it is useful to change definition of the
WitnessVecand make it generic over custom allocator.