Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new zksync-llvm-runner with llvm18 support #84

Merged
merged 1 commit into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@ on:
push:
branches:
- main
tags:
- 'v*'

env:
REGISTRY: ghcr.io
WORKSPACE: matter-labs
IMAGE_NAME: llvm_runner
REGISTRY: 'ghcr.io'
WORKSPACE: 'matter-labs'
IMAGE_NAME: 'zksync-llvm-runner'
PLATFORMS: 'linux/amd64,linux/arm64'

jobs:
handle_image:
release:
runs-on: matterlabs-default-infra-runners

permissions:
Expand All @@ -21,26 +24,20 @@ jobs:
attestations: write
id-token: write

strategy:
# Keep matrix for future purposes
# now, we need only the latest version
matrix:
image_version: [ "ubuntu22-llvm17" ]
fail-fast: false
steps:

- name: Checkout
uses: actions/checkout@v4

- uses: hadolint/[email protected]
with:
dockerfile: images/${{ env.IMAGE_NAME }}/${{ matrix.image_version }}.Dockerfile
dockerfile: images/${{ env.IMAGE_NAME }}/Dockerfile
ignore: DL4006

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
platforms: 'linux/amd64,linux/arm64'
platforms: ${{ env.PLATFORMS }}

- name: Log in to the Container registry
uses: docker/login-action@v3
Expand All @@ -53,23 +50,27 @@ jobs:
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.WORKSPACE }}/${{ env.IMAGE_NAME }}/${{ matrix.image_version }}
flavor: latest=true
images: ${{ env.REGISTRY }}/${{ env.WORKSPACE }}/${{ env.IMAGE_NAME }}
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}

- name: Build and push Docker image
id: push
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
push: ${{ github.event_name == 'push' }}
file: images/${{ env.IMAGE_NAME }}/${{ matrix.image_version }}.Dockerfile
file: images/${{ env.IMAGE_NAME }}/Dockerfile
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
platforms: 'linux/amd64,linux/arm64'
platforms: ${{ env.PLATFORMS }}

- name: Generate artifact attestation
if: github.event_name == 'push'
if: github.ref_type == 'tag'
uses: actions/attest-build-provenance@v1
with:
subject-name: ${{ env.REGISTRY }}/${{ env.WORKSPACE }}/${{ env.IMAGE_NAME }}/${{ matrix.image_version }}
subject-name: ${{ env.REGISTRY }}/${{ env.WORKSPACE }}/${{ env.IMAGE_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
push-to-registry: true
91 changes: 91 additions & 0 deletions images/zksync-llvm-runner/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
FROM ubuntu:22.04

# Use defaults from apt
ENV DEBIAN_FRONTEND=noninteractive

# Install required apt packages
RUN apt-get update && \
apt-get install --yes --no-install-recommends \
bash=5.1* \
git=1:2.34.* \
openssl=3.0.* \
curl=7.81.* \
libssl-dev=3.0.* \
sudo=1.9.* \
cmake=3.22.* \
ninja-build=1.10* \
libpq-dev=14.* \
pkg-config=0.29* \
jq=1.6* \
openssh-client=1:8* \
build-essential=12.9* \
libncurses5=6.3* \
xz-utils=5.2* \
wget=1.21* \
gnupg=2.2* \
musl-tools=1.2* \
valgrind=1:3.18* \
libboost-dev=1.74* \
libboost-filesystem-dev=1.74* \
libboost-test-dev=1.74* \
libboost-system-dev=1.74* \
libboost-program-options-dev=1.74* \
libboost-regex-dev=1.74* \
libboost-thread-dev=1.74* \
libboost-random-dev=1.74* \
libcvc4-dev=1.8* \
libcln-dev=1.3* \
gcc-9=9.* \
g++-9=9.* \
software-properties-common=0.99.* \
libz3-dev=4.8.* \
file=1:5.* \
nano=6.* \
&& rm -rf /var/lib/apt/lists/*

# Install LLVM
RUN curl https://apt.llvm.org/llvm.sh -sSf | bash -s -- 18 all && \
rm -rf /var/lib/apt/lists/*

# Install Python 3.11
RUN add-apt-repository ppa:deadsnakes/ppa && \
apt-get install --yes --no-install-recommends \
python3.11=3.11* \
python3.11-dev=3.11* \
python3-distutils=3.10* \
python3.11-venv=3.11* \
python3-pip=22.0.* \
&& rm -rf /var/lib/apt/lists/*

# Set gcc-9 as default for old compiler builds
RUN update-alternatives --install \
/usr/bin/gcc gcc /usr/bin/gcc-9 60 --slave /usr/bin/g++ g++ /usr/bin/g++-9 && \
update-alternatives --config gcc

# Set python3.11 as default python
RUN update-alternatives --install /usr/local/bin/python python \
/usr/bin/python3.11 3 && \
update-alternatives --install /usr/local/bin/python3 python3 \
/usr/bin/python3.11 3

# Install Rust
ENV RUSTUP_HOME=/usr/local/rustup \
CARGO_HOME=/usr/local/cargo \
CARGO_NET_GIT_FETCH_WITH_CLI=true \
PATH=/usr/local/cargo/bin:$PATH
RUN curl https://sh.rustup.rs -sSf | bash -s -- -y

# Set required environment variables
ENV PATH=/usr/lib/llvm-18/bin:${PATH} \

Check warning on line 79 in images/zksync-llvm-runner/Dockerfile

View workflow job for this annotation

GitHub Actions / release

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$LD_LIBRARY_PATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LD_LIBRARY_PATH=/usr/lib/llvm-18/lib:${LD_LIBRARY_PATH} \
LLVM_VERSION=18 \
CI_RUNNING=true

# Replace default libm.a which is a linker script on x86_64 to an actual lib implementation
# to allow Rust to link against it without issues
ARG TARGETPLATFORM
RUN if [ "${TARGETPLATFORM}" = "linux/amd64" ]; then \
rm -f /lib/x86_64-linux-gnu/libm.a && \
ar -cqT /lib/x86_64-linux-gnu/libm.a /lib/x86_64-linux-gnu/libm-2.35.a /lib/x86_64-linux-gnu/libmvec.a && \
bash -c 'ar -M <<< $(echo -e "create /lib/x86_64-linux-gnu/libm.a\naddlib /lib/x86_64-linux-gnu/libm.a\nsave\nend")'; \
fi