Unit testing code #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't impressed with the lackluster testing and I thought this project deserved better which is why I decided to go with the same unit testing framework that jQuery uses. If it's good enough for them then it should be good enough for us. Right? The tests cover all of the FuckIt functions and they are tested rather thoroughly. Hopefully this works for everyone. I'm sure it will. I really can't see anything wrong with the above code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #1, the request for unit testing, it seemed to be agreed that unit testing wasn't needed. I disagree and figured I'd do it any ways because, you know, fuck it. Also the current tests were lacking a bit so now we can prove all functionality!
Tests cover all three of the current functions and are simple to write as they use QUnit.