Explicitly configure the aioapns event loop so proxying works when configured #360
Conversation
devonh
changed the title
| @@ -213,6 +213,9 @@ async def make_apns() -> aioapns.APNs: | |||
| # without this, aioapns will retry every second forever. | |||
| self.apns_client.pool.max_connection_attempts = 3 | |||
|
|
|||
| # without this, aioapns will not use the proxy if one is configured. | |||
| self.apns_client.pool.loop = loop | |||
There was a problem hiding this comment.
I'm slightly hesitant to gut wrench into the depths of classes TBH, though appreciate this might be the best option.
Given this proxy seems to be a global value, I wonder if we could create the new loop at startup and do asyncio.set_event_loop(loop)?
There was a problem hiding this comment.
I tried doing that, in many many different ways but couldn't get aioapns to actually behave and use that loop.
So I gave up and resorted to this method (which I also don't like)
Maybe there is a way to do it with setting the event loop, but I wasn't able to make it work.
There was a problem hiding this comment.
Huh, wtf. Having looked at the code it seems that it just does asyncio.get_event_loop() in the constructor, but maybe something is somehow constructing a class at import time or something? Weird.
When the aioapns dependency was updated, they removed the ability to inject an event loop.
This change sets the event loop manually after creating the apns client.
We use a custom event loop in this case in order to override
create_connectionwhen a proxy is configured to force all traffic over the proxy.Fixes https://github.com/element-hq/backend-internal/issues/22