Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse user agent into a human-friendly string on submission #86

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Parse user agent into a human-friendly string on submission #86

merged 4 commits into from
Nov 26, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 22, 2024

I've had to look up UA's far too many times

@t3chguy t3chguy self-assigned this Nov 22, 2024
@t3chguy t3chguy marked this pull request as ready for review November 22, 2024 17:22
richvdh
richvdh reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I have slight reservations about feeding untrusted data into a library which doesn't seem to have a documented security posture, but I guess it's fine.

submit.go Outdated Show resolved Hide resolved
submit.go Show resolved Hide resolved
@t3chguy t3chguy requested a review from richvdh November 25, 2024 15:00
richvdh
richvdh approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh merged commit 1d0a896 into main Nov 26, 2024
5 checks passed
@richvdh richvdh deleted the t3chguy/parse-ua branch November 26, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

@t3chguy t3chguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @richvdh