Add header anchors #2570
Merged
Add header anchors #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any test deployment? |
|
Also supersedes #2009. I can't say I'm a huge fan of having to add something of the frontmatter of every single post, but we can adopt it and report to the zola maintainers that it'd be useful to have an option at the folder level |
thibaultamartin
requested changes
Dec 5, 2024
Apparently cloudflare bot was sleepy on this one... |
MTRNord
force-pushed
the
MTRNord/anchors
branch
from
9919a59 to
7785c93
Compare
Deploying matrix-website with
|
| Latest commit: |
7785c93
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6426ba03.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-anchors.matrix-website.pages.dev |
Done |
thibaultamartin
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
I'm sad to approve it, but there is no way around it for now. Thanks for tackling it.
Ideally if you could also update the CONTRIBUTE.md to point out that the insert_anchor_links needs to be in the month/_index.md that would be great. Not blocking on it, we can do in a separate PR if you want.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2367
Fixes #1760
It seems to work I guess? We can improve upon it at a later stage with some design perhaps but this seems sufficient and fixes long standing annoyance