Fix the contrast of links and ensure we underline those links #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTRNord
added
enhancement
Deploying matrix-website with
|
| Latest commit: |
f38166d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62c4058b.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-fix-link-contrast.matrix-website.pages.dev |
MTRNord
force-pushed
the
MTRNord/fix-link-contrast
branch
from
512cf01
to
30d1c01
Compare
|
This seems to have a negative side effect on e.g. CTAs
|
|
Hm I thought it would be ok like that but I can remove the underline for buttons easily :) |
…sing underlining on the footer
|
@thibaultamartin fixed your concern :) |
MTRNord
commented
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some errors from my testing branch. I thought it might be a good idea to get these on a dedicated branch.
Explicitly it fixes https://dequeuniversity.com/rules/axe/4.9/color-contrast and
Ensure links are distinguished from surrounding text in a way that does not rely on colorwhich is part of WCAG 2.1 (A), WCAG 2.0 (A), WCAG 2.2 (A), Trusted Tester and EN 301 549Before and after images
This gives us at least a 5.40:1 contrast ratio on all backgrounds. Which is enough for the AA requirements.