Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that new concerns will cancel FCP #2057

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Jan 15, 2025

idk this is a wild guess about what seems reasonable

Pull Request Checklist

Signed-off-by: HarHarLinks [email protected]

Preview: https://pr2057--matrix-spec-previews.netlify.app

@HarHarLinks HarHarLinks requested a review from a team as a code owner January 15, 2025 22:41
@HarHarLinks
Copy link
Contributor Author

Alternatively, it would seem reasonable that after resolving the concern, FCP can be proposed again.
Seeing as the SCT already agreed on FCP, restarting FCP automatically would be the lighter approach.

@richvdh
Copy link
Member

richvdh commented Jan 15, 2025

I don't think this is correct. IIRC, a concern stops the FCP completing, but doesn't stop the 5-day timer. In other words, if the 5-day timer elapses while the concern is active, the FCP will complete as soon as the concern is resolved.

@tulir
Copy link
Member

tulir commented Jan 15, 2025

The next bullet point already says concerns block the FCP completing, but don't reset the timer, so I don't think any changes are needed?

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as others have said, this isn't what is done in practice. Concerns are intended to prevent the FCP from starting or finishing depending on where it's at, but it doesn't cancel the FCP (cancelling means we have to re-acquire all checkboxes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants